jQuery UI Development

Timestamp:

11/23/08 10:00:29 (16 months ago)

Author:

paul.bakaus

Message:

core (mouse): preventDefault in most cases instead of returning false, that blocks all bubbling events (fixed #3552)

Files:

• trunk/ui/ui.core.js (modified) (2 diffs)

trunk/ui/ui.core.js

@@ -463 +463 @@
                         .bind('mouseup.'+this.widgetName, this._mouseUpDelegate);
 
-                return $.browser.safari; //Fix for safari to allow selecting select options
+                // preventDefault() is used to prevent the selection of text here -
+                // however, in Safari, this causes select boxes not to be selectable
+                // anymore, so this fix is needed 
+                if(!$.browser.safari) event.preventDefault();
+                return true;
         },
 
@@ -474 +478 @@
                 if (this._mouseStarted) {
                         this._mouseDrag(event);
-                        return false;
+                        return event.preventDefault();
                 }