jQuery UI Development

Timestamp:

07/17/08 08:04:42 (20 months ago)

Author:

paul.bakaus

Message:

draggable: fixed relative position bug (please NEVER check in elem.style just for performance optimizations)

Files:

• trunk/ui/ui.draggable.js (modified) (2 diffs)

trunk/ui/ui.draggable.js

@@ -16 +16 @@
         init: function() {
                 
-                //Initialize needed constants
-                var o = this.options, positioned = /^(?:r|a|f)/, element = this.element[0];
-                
-                if (!this.element.length)
+                if (this.options.helper == 'original' && !(/^(?:r|a|f)/).test(this.element.css("position")))
+                        this.element[0].style.position = 'relative';
+
+                (this.options.disabled && this.element.addClass('ui-draggable-disabled'));
+                
+                this.mouseInit();
+                
+        },
+        mouseStart: function(e) {
+                
+                var o = this.options;
+                
+                if (this.helper || o.disabled || $(e.target).is('.ui-resizable-handle'))
                         return false;
-
-                var style = element.style || {}, 
-                        position = style.position || "static"; 
-                
-                //Position the node
-                if (o.helper == 'original' && !positioned.test(position))
-                        style.position = 'relative';
-
-                (o.disabled && this.element.addClass('ui-draggable-disabled'));
-                
-                this.mouseInit();
-                
-        },
-        mouseStart: function(e) {
-                var o = this.options;
-                
-                if (this.helper || o.disabled || $(e.target).is('.ui-resizable-handle')) return false;
-                
+                
+                //Check if we have a valid handle
                 var handle = !this.options.handle || !$(this.options.handle, this.element).length ? true : false;
-                
-        
                 $(this.options.handle, this.element).find("*").andSelf().each(function() {
                         if(this == e.target) handle = true;
@@ -47 +38 @@
                 if (!handle) return false;
                 
-                if($.ui.ddmanager) $.ui.ddmanager.current = this;
+                if($.ui.ddmanager)
+                        $.ui.ddmanager.current = this;
                 
                 //Create and append the visible helper