Ticket #3188 (closed bug: fixed)

Opened 19 months ago

Last modified 16 months ago

prevent exposure of internal methods

Reported by: scott.gonzalez Owned by: scott.gonzalez
Priority: blocker Milestone: 1.6rc1
Component: ui.core Version: 1.5.2
Keywords: Cc:

Description

Internal plugin methods should not be callable using the plugin API.

Example:

$(el).plugin('internalMethod');

Change History

Changed 19 months ago by scott.gonzalez

  • status changed from new to accepted

This will be handled by the widget factory. Precede internal method names with an underscore to prevent exposure through the API.

Changed 19 months ago by scott.gonzalez

The widget factory was modified to support this in r547.

Changed 19 months ago by scott.gonzalez

  • status changed from accepted to closed
  • resolution set to fixed

There is a separate ticket for each plugin:

#3194 ui.accordion
#3195 ui.autocomplete
#3196 ui.colorpicker
#3197 ui.datepicker
#3198 ui.dialog
#3200 ui.draggable
#3201 ui.droppable
#3202 ui.magnifier
#3203 ui.progressbar
#3204 ui.resizable
#3205 ui.selectable
#3206 ui.slider
#3209 ui.sortable
#3207 ui.spinner
#3208 ui.tabs

Changed 19 months ago by Cloudream

  • status changed from closed to reopened
  • resolution fixed deleted

After individual plugins fixed, we should fix init/plugins to _init/_plugins

Changed 19 months ago by scott.gonzalez

Widget factory methods updated in r552.

Changed 19 months ago by Cloudream

only mouse* in drag/drop/sort/select left.

Changed 19 months ago by Cloudream

  • status changed from reopened to closed
  • resolution set to fixed

Changed 19 months ago by scott.gonzalez

  • status changed from closed to reopened
  • resolution fixed deleted

mouse* in slider still needs to be updated.

Changed 19 months ago by Cloudream

  • status changed from reopened to closed
  • resolution set to fixed

done and pass the test case.

Changed 16 months ago by rdworth

  • milestone changed from 1.6 to 1.6rc1
Note: See TracTickets for help on using tickets.